When offering code-completion suggestions, the generated code will now take
into account any namespaces explicitly qualified with a using-directive
BUG: 373722
Details
Details
- Reviewers
- None
- Group Reviewers
KDevelop
The test_codecompletion tests are broken (as confirmed on IRC),
but an individual test case can be run before the crash
$ ./test_codecompletion testImplement:bug373722-using-directive
Diff Detail
Diff Detail
- Repository
- R32 KDevelop
- Branch
- implements-fix
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 3447 Build 3465: arc lint + arc unit
Comment Actions
Added a test.
But, as I've mentioned before, the tests for code completion crash,
So I haven't been able to run all tests, though you can run a single test case
before it crashes.
There's another thing, the visitor will keep scanning even past the invocation
point, even though function declarations (and using-directives) after the
invocation point shouldn't be considered while making suggestions. Would it
better to create a new patch and test the file/line to break the visitor ?
Comment Actions
The simple example
namespace A
{
void foo();
}
using namespace A;
void foo()
{
std::cout << "foo" << std::endl;
}Doesn't work, because the function definition doesn't implement ::A::foo but ::foo. Although it would work in some other cases... I figure it's not worth supporting.