Fix signals not being emitted when merging two persons
ClosedPublic

Authored by poboiko on Sep 30 2018, 9:20 AM.

Details

Summary

If I have 4 contacts, i.e. {A,B,C,D}, then merge {A,B}->1 and {C,D}->2, and then merge {1,2}->1,
inside the model I get only signals that contacts {C,D} were removed from person 2, ending up with 3 contacts in the model {1,C,D}, instead of just 1.
Apparently, the line was simply missing.

Test Plan

With this patch, merging works as expected

Diff Detail

Repository
R307 KPeople
Branch
forgotten-signal (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3356
Build 3374: arc lint + arc unit
poboiko created this revision.Sep 30 2018, 9:20 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 30 2018, 9:20 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
poboiko requested review of this revision.Sep 30 2018, 9:20 AM
dvratil accepted this revision.Oct 1 2018, 7:46 AM
This revision is now accepted and ready to land.Oct 1 2018, 7:46 AM
poboiko closed this revision.Oct 1 2018, 10:40 AM