Differential D15838

[Telephony] Check last state before handling broadcast
ClosedPublic
Actions

Authored by nicolasfella on Sep 29 2018, 6:08 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R225:297f0f66f596: [Telephony] Check last state before handling broadcast
Summary

Bug: 396954

Sometimes multiple broadcasts with the same state arrive. Only handle them when the state actually changes

Test Plan

Get called, "Calling" notification appears. Caller hangs up, "Call missed" notification appears.

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Sep 29 2018, 6:08 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptSep 29 2018, 6:08 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Sep 29 2018, 6:09 PM
albertvaka accepted this revision.Sep 30 2018, 5:03 AM
albertvaka added a subscriber: albertvaka.

Nice!

This revision is now accepted and ready to land.Sep 30 2018, 5:03 AM
Closed by commit R225:297f0f66f596: [Telephony] Check last state before handling broadcast (authored by nicolasfella). · Explain WhySep 30 2018, 5:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 42616

View Options

src/org/kde/kdeconnect/Plugins/TelephonyPlugin/TelephonyPlugin.java

Loading...