Remove expensive blocking call on plasmashell startup
ClosedPublic

Authored by davidedmundson on Fri, Sep 28, 2:03 PM.

Details

Summary

QDBusInterface is a blocking call that calls introspect. We don't need
to introspect.

As this is called on startup this call starts kuiserver, which means
plasma is blocked whilst a whole process spawns, this is a lot worse
than just a regular, ~100ms on my system

Also using the generated versions is generally neater to read.

Test Plan

Restarted plasmashell
Copied a file
Still had a spinny wheel
Q_DBUS_BLOCKING_CALL_MAIN_THREAD_WARNING_MS=0 doesn't list kuiserver

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Fri, Sep 28, 2:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, Sep 28, 2:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Fri, Sep 28, 2:03 PM
broulik accepted this revision.Fri, Sep 28, 2:17 PM
broulik added a subscriber: broulik.

Nice one

This revision is now accepted and ready to land.Fri, Sep 28, 2:17 PM
This revision was automatically updated to reflect the committed changes.