Differential D15781

[smsapp] Use ApplicationHeader instead of ToolbarApplicationHeader
ClosedPublic
Actions

Authored by nicolasfella on Sep 26 2018, 7:58 PM.

Details

Reviewers
apol
Group Reviewers
KDE Connect
Commits
R224:f82df1c46164: [smsapp] Use ApplicationHeader instead of ToolbarApplicationHeader
Summary

ToolbarApplicationHeader seems deprecated and is broken on Plasma Mobile

Before:

After:

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Sep 26 2018, 7:58 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptSep 26 2018, 7:58 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Sep 26 2018, 7:58 PM
nicolasfella edited the summary of this revision. (Show Details)Sep 26 2018, 8:03 PM
nicolasfella edited the summary of this revision. (Show Details)
apol accepted this revision.Sep 27 2018, 1:02 AM
apol added a subscriber: apol.

Works for me, not that the sms app makes a lot of sense on PM though... :P

This revision is now accepted and ready to land.Sep 27 2018, 1:02 AM
Closed by commit R224:f82df1c46164: [smsapp] Use ApplicationHeader instead of ToolbarApplicationHeader (authored by nicolasfella). · Explain WhySep 27 2018, 4:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msmsapp/qml/main.qml (2 lines)

Diff 42436

View Options

smsapp/qml/main.qml

Loading...