Fix using kscreen with qxl, follow the preferred mode
AbandonedPublic

Authored by apol on Sep 26 2018, 1:48 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

When using a the qxl driver (for virtual machines), we'll be getting resizes of
the display by changes on the preferred output id.
The status quo is that if one runs xrandr --output Virtual-0 --preferred after
resizing the screen, kscreen will be set on the right outputId and just work.
This shouldn't have an impact on normal use-cases because it's very strange that
the preferred mode changes at runtime.

Test Plan

Ran it on my laptop, nothing broke. Will test on QXL in a bit.

Diff Detail

Repository
R104 KScreen
Branch
preferred (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3233
Build 3251: arc lint + arc unit
apol created this revision.Sep 26 2018, 1:48 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 26 2018, 1:48 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Sep 26 2018, 1:48 PM
broulik added inline comments.
kded/daemon.cpp
421

Doesn't this also need to be a UniqueConnection then?

apol abandoned this revision.Sep 26 2018, 4:25 PM

Sorry for the noise, this doesn't work.