BUG: 398960
FIXED-IN: 5.14.0
Details
Details
Switching icon sets between newaita, Breeze, or Oxygen no longer results in
different (too large) icon sizes to be used.
Diff Detail
Diff Detail
- Repository
- R114 Plasma Addons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I think all of this could be cleaned up significantly
| applets/weather/package/contents/ui/ForecastView.qml | ||
|---|---|---|
| 38 | Layout.preferredWidth defaults to implicitWidth, see [1] on the "preference order" [1] https://doc.qt.io/qt-5/qtquicklayouts-overview.html#specifying-preferred-size | |
| 114 | You can just do children[i].Layout.preferredWidth, no need for a "proxy" property Also, shouldn't it rather be for (var i = 0; i < repeater.count; ++i) {
var child = repeater.itemAt(i);
...
}Also I *think* that should auto-propagate, no? | |
Comment Actions
Thanks for look, Will update based on feedback later today.
| applets/weather/package/contents/ui/ForecastView.qml | ||
|---|---|---|
| 38 | I did this code to spare some `if Layout && Layout.preferredWidth && Layout.preferredWidth > 0 { use Layout.preferredWidth } else { else use implicitWidth) in the calculation, seems that was not obvious outside my brain :) | |
| 114 | Had not yet tried to look at repeater childs, let me try that. At least from what I remember about testing any auto-propagation from repeater & loader, this did not work as expected, so I turned to do all explicitly. Though not exactly sure what you mean with "that"? | |
Comment Actions
- use Repeater.count & Repeater.itemAt(i)
- drop additional property preferredWidth on cell items, calculate from normal properties