Differential D15708

[effects/slide] Delete redundant checks
ClosedPublic
Actions

Authored by zzag on Sep 23 2018, 12:06 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:72ad5dc8948c: [effects/slide] Delete redundant checks
Summary

If isActive() returns false, neither paintScreen nor paintWindow nor
postPaintScreen will be called.

So, if (m_active) checks are redundant.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Sep 23 2018, 12:06 PM
Restricted Application added a project: KWin. · View Herald TranscriptSep 23 2018, 12:06 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Sep 23 2018, 12:06 PM
davidedmundson accepted this revision.Sep 26 2018, 4:10 PM
This revision is now accepted and ready to land.Sep 26 2018, 4:10 PM
Closed by commit R108:72ad5dc8948c: [effects/slide] Delete redundant checks (authored by zzag). · Explain WhySep 28 2018, 5:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Meffects/slide/slide.cpp (25 lines)

Diff 42511

View Options

effects/slide/slide.cpp

Loading...