Set view to track new elements as they are added
ClosedPublic
Actions

Authored by sredman on Sep 16 2018, 9:15 PM.

Details

Reviewers

Commits

R224:d742684d2147: Set view to track new elements as they are added

Summary

Set the currentIndex of the ConversationDisplay to show the newest messages by default, but stay where the user positioned it if viewing older messages

Test Plan

Launch SMS App:

Select conversation
View should show the most recent messages
Receive new message
View should scroll to show the new message
Scroll up to view older messages
Receive new message
View should continue to show older messages and not scroll to the bottom

Diff Detail

Repository

R224 KDE Connect

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

sredman created this revision.Sep 16 2018, 9:15 PM

Restricted Application added a project: KDE Connect. · View Herald TranscriptSep 16 2018, 9:15 PM

Restricted Application added a subscriber: kdeconnect. · View Herald Transcript

sredman requested review of this revision.Sep 16 2018, 9:15 PM

Harbormaster completed remote builds in B2938: Diff 41777.Sep 16 2018, 9:15 PM

sredman mentioned this in T9555: Conversation view should scroll to the bottom (most-recent) message by default.Sep 16 2018, 9:17 PM

Nice!

This revision is now accepted and ready to land.Sep 16 2018, 9:47 PM

Closed by commit R224:d742684d2147: Set view to track new elements as they are added (authored by sredman). · Explain WhySep 16 2018, 9:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			smsapp/qml/ConversationDisplay.qml (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	41777	707a4bd		Sep 16 2018, 9:15 PM	★	★
Diff 2	41779	707a4bd	R224:d742684d214782aebb65448953ab30ad5287db96	Sep 16 2018, 9:52 PM	★	★

Diff 41779

View Options

smsapp/qml/ConversationDisplay.qml