[Android] Cleanup SMS plugin and document deprecated SMS-relevant Telephony packet types
ClosedPublic

Authored by sredman on Sep 15 2018, 8:52 PM.

Details

Summary
  • Rename all SMS-handling packets to indicate that they belong to the SMS plugin
  • Define TELEPHONY_REQUEST_MUTE packet to replace TELEPHONY_REQUEST packet

Please see KDE-side patch here: D15543

Test Plan

See test plan in D15543

Diff Detail

Repository
R225 KDE Connect - Android application
Branch
sms-packet-update
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2941
Build 2959: arc lint + arc unit
sredman created this revision.Sep 15 2018, 8:52 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptSep 15 2018, 8:52 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
sredman requested review of this revision.Sep 15 2018, 8:52 PM
sredman updated this revision to Diff 41759.Sep 16 2018, 5:37 PM

Do not disable sending notifications for SMS applications by default

sredman updated this revision to Diff 41762.Sep 16 2018, 6:00 PM

Update telephony plugin description to reflect SMS being moved to a new plugin

nicolasfella accepted this revision.Sep 16 2018, 8:11 PM
nicolasfella added a subscriber: nicolasfella.

Some nitpicks, otherwise looks good

src/org/kde/kdeconnect/Plugins/SMSPlugin/SMSPlugin.java
96

can be private

105

Can be private

274

Can be private

This revision is now accepted and ready to land.Sep 16 2018, 8:11 PM
sredman updated this revision to Diff 41781.Sep 16 2018, 10:04 PM

Make stuff private

nicolasfella accepted this revision.Sep 16 2018, 10:05 PM
sredman marked 3 inline comments as done.Sep 16 2018, 10:05 PM
sredman closed this revision.Sep 16 2018, 10:07 PM