Differential D1553

Fix broken corrupt query
ClosedPublic
Actions

Authored by elvisangelaccio on May 7 2016, 11:44 AM.

Details

Reviewers
rthomsen
Summary

The LoadCorruptQuery is currently broken on master. Ark always loads a corrupt archive,
even if the user clicks Don't Open.

This is due to the finished() signal already emitted when the query pops up.
A simple fix is to run the query in processFinished(), if we detected that the
archive is corrupt.

Test Plan

Corrupt query works again.

Diff Detail

Repository
R36 Ark
Branch
fix-corrupt-query
Lint
No Linters Available
Unit
No Unit Test Coverage
elvisangelaccio updated this revision to Diff 3686.May 7 2016, 11:44 AM
elvisangelaccio retitled this revision from to Fix broken corrupt query.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptMay 7 2016, 11:44 AM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
rthomsen accepted this revision.May 27 2016, 5:48 PM
rthomsen edited edge metadata.

Ship it! :)

This revision is now accepted and ready to land.May 27 2016, 5:48 PM

Revision Contents
Changeset List

PathPackages
Mkerfuffle/cliinterface.cpp (24 lines)

Diff 3686

View Options

kerfuffle/cliinterface.cpp

Loading...