Enable XAR support
ClosedPublic
Actions

Authored by rthomsen on May 6 2016, 10:06 PM.

Details

Reviewers

Commits

Summary

This diff enables read-only support for XAR achives in libarchiveplugin. It seems libarchive has partial read-write support for this format, but I encountered an error when attempting to create a Xar archive.

Things to consider:
Shared-mime-info 1.6 (released in February 2016) contains the mimetype for XAR. Should we install the mimetype for XAR ourselves in case the user has an older shared-mime-info?

Test Plan

Mimetypetest and archivetest were added for Xar.

Test archive:

simplearchive.xar1 KBDownload

Diff Detail

Repository

R36 Ark

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

rthomsen updated this revision to Diff 3682.May 6 2016, 10:06 PM

rthomsen retitled this revision from to Enable XAR support.

rthomsen updated this object.

rthomsen edited the test plan for this revision. (Show Details)

rthomsen added a reviewer: elvisangelaccio.

rthomsen set the repository for this revision to R36 Ark.

rthomsen added a project: Ark.

Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptMay 6 2016, 10:06 PM

Let's also install the mimetype, just to be sure. For example Kubuntu 16.04 is stuck to shared-mime-info 1.5...

Install mimetype in case user is running shared-mime-info < 1.6.

elvisangelaccio accepted this revision.May 7 2016, 9:59 AM

elvisangelaccio edited edge metadata.

This revision is now accepted and ready to land.May 7 2016, 9:59 AM

Closed by commit R36:5dff013d4a3f: Add XAR support (authored by rthomsen). · Explain WhyMay 7 2016, 4:28 PM

This revision was automatically updated to reflect the committed changes.

rthomsen mentioned this in R36:5dff013d4a3f: Add XAR support.

Revision Contents
Changeset List

			Path
M			autotests/kerfuffle/archivetest.cpp (23 lines)
A	M	(bin)	autotests/kerfuffle/data/simplearchive.xar
M			autotests/kerfuffle/mimetypetest.cpp (2 lines)
M			kerfuffle/mime/kerfuffle.xml (8 lines)
M			plugins/libarchive/CMakeLists.txt (2 lines)
M			plugins/libarchive/kerfuffle_libarchive_readonly.json (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3682			May 6 2016, 10:00 PM	★	★
Diff 2	3684			May 7 2016, 9:53 AM	★	★
Diff 3	3687	268ad34	rARK5dff013d4a3fdc473bc17d608c822a221aa75f01	May 7 2016, 4:22 PM	★	★