Details

Reviewers

yurchor
sitter

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

R548:76e457b0d506: Forward declare QtDBus classes

Summary

Forward declare QtDBus classes as we do not want to publically link to the library

Diff Detail

Repository

R548 QAPT Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

jriddell created this revision.Sep 14 2018, 12:09 PM

Owners added a reviewer: Restricted Owners Package.Sep 14 2018, 12:09 PM

jriddell requested review of this revision.Sep 14 2018, 12:09 PM

Harbormaster completed remote builds in B2855: Diff 41642.Sep 14 2018, 12:10 PM

Arc doesn't compile because it can't find the QtDBus headers. This makes it compile

current fail:
https://build.neon.kde.org/job/bionic_unstable_extras_qapt_bin_amd64/6/console

with this change, green:
https://build.neon.kde.org/view/Bionic%20Git%20Unstable/job/bionic_unstable_extras_qapt/6/

jriddell added subscribers: sitter, yurchor, vanini.Sep 14 2018, 12:12 PM

yurchor accepted this revision.Sep 14 2018, 12:59 PM

This revision is now accepted and ready to land.Sep 14 2018, 12:59 PM

That is wrong.

QDBusVariant needs to be forward declared in the header and included in the cpp. There is no public dependency on qtdbus.

This revision now requires changes to proceed.Sep 14 2018, 1:42 PM

Forward declaire QtDBus classes

Harbormaster completed remote builds in B2985: Diff 41892.Sep 18 2018, 11:04 AM

Forward declaire QtDBus classes as we do not want to publically link to the library

Harbormaster completed remote builds in B2986: Diff 41893.Sep 18 2018, 11:07 AM

Forward declaire QtDBus classes as we do not want to publically link to the library

Harbormaster completed remote builds in B2987: Diff 41894.Sep 18 2018, 11:08 AM

sitter accepted this revision.Sep 18 2018, 11:12 AM

sitter retitled this revision from Revert "Revert "fix includes so it can find QDBus"" to Forward declare QtDBus classes.

sitter edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.Sep 18 2018, 11:13 AM

Closed by commit R548:76e457b0d506: Forward declare QtDBus classes (authored by jriddell, committed by vanini). · Explain WhySep 24 2018, 12:57 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/downloadprogress.h (3 lines)
M			src/downloadprogress.cpp (1 line)
M			src/transaction.h (2 lines)
M			src/transaction.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	41642	7cda63e		Sep 14 2018, 12:09 PM	★	★
Diff 2	41892	7cda63e	Forward declaire QtDBus classes	Sep 18 2018, 11:04 AM	★	★
Diff 3	41893	7cda63e	- Forward declaire QtDBus classes as we do not want to publically link to the…	Sep 18 2018, 11:07 AM	★	★
Diff 4	41894	7cda63e	- Forward declaire QtDBus classes as we do not want to publically link to the…	Sep 18 2018, 11:08 AM	★	★
Diff 5	42239	7cda63e	R548:76e457b0d5068cf714efa5a68729378f307c54e2	Sep 24 2018, 12:56 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
d1f002f734fb	7e3429ea0d37	658411f0e1ce	Jonathan Riddell	Forward declaire QtDBus classes as we do not want to publically link to the… (Show More…)	Sep 18 2018, 11:06 AM
658411f0e1ce	4285d7842254	7cda63e84163	Jonathan Riddell	Forward declaire QtDBus classes (Show More…)	Sep 18 2018, 11:00 AM

Forward declare QtDBus classes
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 42239

src/downloadprogress.h

src/downloadprogress.cpp

src/transaction.h

src/transaction.cpp

Forward declare QtDBus classesClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 42239

src/downloadprogress.h

src/downloadprogress.cpp

src/transaction.h

src/transaction.cpp

Forward declare QtDBus classes
ClosedPublic
Actions

Revision Contents
Changeset List