Forward declare QtDBus classes as we do not want to publically link to the library
Details
Details
- Reviewers
yurchor sitter - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- R548:76e457b0d506: Forward declare QtDBus classes
Diff Detail
Diff Detail
- Repository
- R548 QAPT Library
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Arc doesn't compile because it can't find the QtDBus headers. This makes it compile
current fail:
https://build.neon.kde.org/job/bionic_unstable_extras_qapt_bin_amd64/6/console
with this change, green:
https://build.neon.kde.org/view/Bionic%20Git%20Unstable/job/bionic_unstable_extras_qapt/6/
Comment Actions
That is wrong.
QDBusVariant needs to be forward declared in the header and included in the cpp. There is no public dependency on qtdbus.