Differential D1547

Don't reset InputDevicesModel when devices change
ClosedPublic
Actions

Authored by graesslin on May 6 2016, 12:50 PM.

Details

Reviewers
bshah
Group Reviewers
Plasma
Commits
R108:a3ca25ecd495: Don't reset InputDevicesModel when devices change
Summary

Instead of reset a proper beginInsertRows, beginRemoveRows is used.
In addition changes in the device are also listened on and emit the
proper dateChanged signal.

Test Plan

Opened debug console, selected the touchpad device,
toggled shortcut and verified that this updated the data column.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 3673.May 6 2016, 12:50 PM
graesslin retitled this revision from to Don't reset InputDevicesModel when devices change.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptMay 6 2016, 12:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bshah accepted this revision.May 13 2016, 7:59 AM
bshah added a reviewer: bshah.
This revision is now accepted and ready to land.May 13 2016, 7:59 AM
Closed by commit R108:a3ca25ecd495: Don't reset InputDevicesModel when devices change (authored by graesslin). · Explain WhyMay 13 2016, 8:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdebug_console.h (10 lines)
Mdebug_console.cpp (54 lines)

Diff 3799

View Options

debug_console.h

Loading...
View Options

debug_console.cpp

Loading...