Spelling corrections in kde-connect sftp plugin
ClosedPublic
Actions

Authored by dominus on Sep 13 2018, 1:15 PM.

Details

Reviewers

kdeconnect
nicolasfella

Commits

R224:e409cdfdaa04: Spelling corrections in kde-connect sftp plugin

Diff Detail

Repository

R224 KDE Connect

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dominus created this revision.Sep 13 2018, 1:15 PM

Restricted Application added a project: KDE Connect. · View Herald TranscriptSep 13 2018, 1:15 PM

Restricted Application added a subscriber: kdeconnect. · View Herald Transcript

dominus requested review of this revision.Sep 13 2018, 1:15 PM

dominus added a reviewer: kdeconnect.Sep 13 2018, 1:17 PM

Thanks! To merge this I will need you email address, please

This revision is now accepted and ready to land.Sep 13 2018, 2:28 PM

In D15478#325255, @nicolasfella wrote:

Thanks! To merge this I will need you email address, please

Please use mjd@plover.com.

Is there something I should have done differently to have communicated this to you already? The patch that git-format-patch generated and that I pasted into the form for review already had the email address in it, but it seems to have been stripped. I do not see a place in the Phabricator profile to specify a public email address.

nicolasfella accepted this revision.Sep 13 2018, 2:55 PM

This revision is now accepted and ready to land.Sep 13 2018, 2:55 PM

Closed by commit R224:e409cdfdaa04: Spelling corrections in kde-connect sftp plugin (authored by dominus, committed by nicolasfella). · Explain WhySep 13 2018, 2:56 PM

This revision was automatically updated to reflect the committed changes.

It's best to use arc for uploading patches. It automatically provides the email and also more context which helps reviewing.