Port away from deprecated KFilterProxySearchLine
ClosedPublic

Authored by kossebau on Sep 10 2018, 9:53 PM.

Details

Summary

The clazy & cppcheck config UIs did not even make use of attaching the
search line to a proxy model.

Diff Detail

Repository
R32 KDevelop
Branch
portawayfromfilteredit
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2698
Build 2716: arc lint + arc unit
kossebau created this revision.Sep 10 2018, 9:53 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptSep 10 2018, 9:53 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
kossebau requested review of this revision.Sep 10 2018, 9:53 PM
antonanikin accepted this revision.Sep 11 2018, 6:21 AM
antonanikin added a subscriber: antonanikin.

LGFM

plugins/kdeprovider/filterproxysearchline.cpp
46

What's about moving default into header?

plugins/kdeprovider/kdeproviderwidget.cpp
49

maybe auto filterLine = new ... ? Less characters :)

This revision is now accepted and ready to land.Sep 11 2018, 6:21 AM
kossebau marked 2 inline comments as done.Sep 11 2018, 9:15 AM
kossebau added inline comments.
plugins/kdeprovider/filterproxysearchline.cpp
46

Left-over from variant where I put this into kdevplatform/util (and personal preference to put any non-inline or virtual methods into source, not header) :)

Removed completly now, for being a private method and no need to promote the own destructor here.

plugins/kdeprovider/kdeproviderwidget.cpp
49

Tried to adapt to the neighbourhood, but then the (analyzer tool-recommended) future is to not repeat the type for the result of new, indeed, and I agree, so embrace the change, neighbourhood!

This revision was automatically updated to reflect the committed changes.
kossebau marked 2 inline comments as done.