Differential D1531

Fix delete on header-encrypted archives
ClosedPublic
Actions

Authored by elvisangelaccio on May 3 2016, 5:54 PM.

Tags

Subscribers

kde-utils-devel

Details

Reviewers

Summary

We were just ignoring the password prompt. Now we use the password switch (since we already know the password).

Test Plan

Deleting entries from header-encrypted archives now works.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Unit Tests Skipped

elvisangelaccio updated this revision to Diff 3627.May 3 2016, 5:54 PM

elvisangelaccio retitled this revision from to Fix delete on header-encrypted archives.

elvisangelaccio updated this object.

elvisangelaccio edited the test plan for this revision. (Show Details)

elvisangelaccio added a reviewer: rthomsen.

elvisangelaccio set the repository for this revision to R36 Ark.

elvisangelaccio added a project: Ark.

elvisangelaccio added a subscriber: kde-utils-devel.

rthomsen requested changes to this revision.May 3 2016, 5:59 PM

rthomsen edited edge metadata.

rthomsen added inline comments.

kerfuffle/cliinterface.cpp
765–774	Do we really need a separate function for this? It seems to be only called once...

This revision now requires changes to proceed.May 3 2016, 5:59 PM

Dropped redundant function

Ship it! :)

This revision is now accepted and ready to land.May 3 2016, 6:13 PM

Closed with cdcd6c1.

kerfuffle/cliinterface.cpp
765–774	Yeah, indeed (I just copy-pasted from copyFilesList, which is also called only once...)

Revision Contents
Changeset List

			Path	Packages
M			kerfuffle/cliinterface.h (2 lines)
M			kerfuffle/cliinterface.cpp (59 lines)
M			plugins/cli7zplugin/cliplugin.cpp (1 line)
M			plugins/clirarplugin/cliplugin.cpp (1 line)

Diff 3628

kerfuffle/cliinterface.h

Loading...

kerfuffle/cliinterface.cpp

Loading...

plugins/cli7zplugin/cliplugin.cpp

Loading...

plugins/clirarplugin/cliplugin.cpp

Loading...