Differential D15184

Work around QTBUG-57299
ClosedPublic
Actions

Authored by rempt on Aug 31 2018, 12:20 PM.

Details

Reviewers
None
Group Reviewers
Krita
Commits
R37:0f36057d79b0: Temporary workaround for QTBUG-57299
R37:eaae2dd1487b: Temporary workaround for QTBUG-57299
Summary

QTBUG-57299 is still actual. This diff works around that by using a temporary file instead of a qsavefile on Windows, like we used to do.

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rempt requested review of this revision.Aug 31 2018, 12:20 PM
rempt created this revision.
dkazakov added a subscriber: dkazakov.Sep 2 2018, 2:55 PM
dkazakov added inline comments.
libs/ui/KisImportExportManager.cpp
622

I think the temporary file must be created in the same directory with the destination file. Otherwise, moving the file on save-completion may become too slow because of copying between different partitions.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 3 2018, 7:48 AM
Closed by commit R37:0f36057d79b0: Temporary workaround for QTBUG-57299 (authored by rempt). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlibs/ui/KisImportExportManager.cpp (50 lines)

Diff 40891

View Options

libs/ui/KisImportExportManager.cpp

Loading...