Custom toolbars
AbandonedPublic
Actions

Authored by mart on Aug 30 2018, 12:58 PM.

Details

Reviewers

Group Reviewers

Summary

make it possible for a Page to replace the content of the otherwise
automatically generated toolbar
The toolbar will go on top in case the toolbar mode is a toobar, and will go on the bottom
replacing the FAB otherwise

Test Plan

tested only on very simple custom items

Diff Detail

Repository

R169 Kirigami

Branch

mart/customToolBar

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 2360
Build 2378: arc lint + arc unit

mart created this revision.Aug 30 2018, 12:58 PM

Restricted Application added a project: Kirigami. · View Herald TranscriptAug 30 2018, 12:58 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart requested review of this revision.Aug 30 2018, 12:58 PM

Harbormaster completed remote builds in B2356: Diff 40702.Aug 30 2018, 12:58 PM

mart added a reviewer: lepagevalleeemmanuel.Aug 30 2018, 12:59 PM

don't scroll away bottom toolbars
simplify code a bit
add some paddings
clean code a bit

Harbormaster completed remote builds in B2360: Diff 40711.Aug 30 2018, 4:27 PM

+1 cool stuff!

mart abandoned this revision.Feb 21 2019, 3:18 PM

Revision Contents
Changeset List

			Path	Packages
M			src/controls/AbstractApplicationHeader.qml (6 lines)
M			src/controls/Page.qml (120 lines)
M			src/controls/PageRow.qml (19 lines)
M			src/controls/private/AbstractPageHeader.qml (13 lines)
M			src/controls/private/ActionButton.qml (2 lines)
M			src/controls/private/TitlesPageHeader.qml (2 lines)
M			src/controls/private/ToolBarPageHeader.qml (148 lines)
M			src/controls/templates/AbstractApplicationHeader.qml (20 lines)
M			src/styles/org.kde.desktop/AbstractApplicationHeader.qml (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	40702	3a7d227		Aug 30 2018, 12:58 PM	★	★
Diff 2	40711	3a7d227	- don't scroll away bottom toolbars	Aug 30 2018, 4:27 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
c748ce8a1194	1bdf5507cc41	cbbe2baa015f	Marco Martin	clean code a bit	Aug 30 2018, 4:27 PM
cbbe2baa015f	eb837fbc2b4b	4d2663dba162	Marco Martin	add some paddings	Aug 30 2018, 4:21 PM
4d2663dba162	45dd9b0be0fa	001cbf68ec5b	Marco Martin	simplify code a bit	Aug 30 2018, 3:35 PM
001cbf68ec5b	62ce2749d646	e2663e866b06	Marco Martin	don't scroll away bottom toolbars	Aug 30 2018, 1:52 PM
e2663e866b06	264ba92d2d56	afa3c9631c5d	Marco Martin	support the custom toolbar as footer as well	Aug 29 2018, 3:21 PM
afa3c9631c5d	8082f6b14e68	b02f4d966485	Marco Martin	fix separators look	Aug 29 2018, 1:41 PM
b02f4d966485	11da7937ed14	ef23a56dfe09 3a7d227e71af	Marco Martin	Merge branch 'master' into mart/customToolBar	Aug 29 2018, 12:39 PM
ef23a56dfe09	7361f8beeaa0	7181915c909b	Marco Martin	start on custom toolbars	Aug 7 2018, 2:18 PM