Add basic test functionality
ClosedPublic

Authored by rthomsen on Apr 30 2016, 9:26 PM.

Details

Summary

This diff adds a TestJob and associated action in Part. Test functionality is enabled in plugin json files, currently for clizip, clirar and cli7z. Test results are displayed simple as success/failure in a KMessageBox.

We can work on a more elaborate UI showing files that failed etc. in a separate patch.

Testing password-protected archives will currently result in an errorbox, due to these archives potentially having different passwords for each file and hence multiple password prompts might pop up.

Bug 140492 (reported in 2007!!)

T966

Test Plan
  • Open various types of supported archives and run the tests.
  • The "Test" action should be disabled for libarchiveplugin.
  • Autotests pass.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rthomsen updated this revision to Diff 3581.Apr 30 2016, 9:26 PM
rthomsen retitled this revision from to Add basic test functionality.
rthomsen updated this object.
rthomsen edited the test plan for this revision. (Show Details)
rthomsen added a reviewer: elvisangelaccio.
rthomsen set the repository for this revision to R36 Ark.
rthomsen added a project: Ark.
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptApr 30 2016, 9:26 PM
rthomsen updated this object.Apr 30 2016, 9:39 PM
elvisangelaccio added inline comments.May 1 2016, 4:07 PM
part/part.cpp
396

"Test Integrity" as action text?

rthomsen updated this revision to Diff 3613.May 2 2016, 5:20 PM

Change text of action to "Test Integrity"

rthomsen marked an inline comment as done.May 2 2016, 5:20 PM
elvisangelaccio accepted this revision.May 3 2016, 4:18 PM
elvisangelaccio edited edge metadata.
This revision is now accepted and ready to land.May 3 2016, 4:18 PM
This revision was automatically updated to reflect the committed changes.