Currently these tooltips only appear in 'Browse' mode. KDE bug https://bugs.kde.org/show_bug.cgi?id=397783 asks for them to be shown in 'text selection' mode, too. I don't really see a reason to disable them in any mode, and therefore this patch simply removes the check for the mouse mode completely.
Details
Details
- Reviewers
aacid - Group Reviewers
Okular - Commits
- R223:81ac73fcf5ce: Show tooltips when hovering over links in mouse selection modes as well.
1 Open a pdf file with an internal or hyperlink
2 Switch to Browse mode
3 Hover over the link: a tooltip with the link target appears
4 Switch to text selection, zoom, magnifier, or any other mouse mode
5 Repeat Step 3: it still works
Diff Detail
Diff Detail
- Repository
- R223 Okular
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I disagree that they should show for all modes, imho we should only do it for the modes that turn the cursor into a hand when hovering the link, otherwise people may think they can "use" the link since it's giving hover information but you won't be able to
Comment Actions
The updates diff makes the tooltips appear in the modes "Browse", "Selection", "Text selection", "Trim selection". These are the ones where the cursor changes to a hand when hovering over a link.
Comment Actions
Looks good.
Make sure you add the BUG keyword on the commit.
Also ideally we'd add an auto test so that this doesn't break, but it's not that important either so if it breaks again i guess we can fix it :)