Only check --shared-mode if llvm is 3.8.0 or newer. This test will be needed for clazy.
ClosedPublic
Actions

Authored by vonreth on Apr 29 2016, 5:13 PM.

Details

Reviewers

mwolff
kfunk

Commits

Repository

R32 KDevelop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

vonreth retitled this revision from to Only check --shared-mode if llvm is 3.8.0 or newer. This test will be needed for clazy..

vonreth updated this object.

vonreth edited the test plan for this revision. (Show Details)

vonreth added reviewers: kfunk, mwolff.

Rest LGTM

cmake/modules/FindLLVM.cmake
118	`LLVM_VERSION` is sufficient, no `${}` needed.

This revision is now accepted and ready to land.May 1 2016, 9:39 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			cmake/modules/FindLLVM.cmake (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3562	a5cee71		Apr 29 2016, 5:13 PM	★	★
Diff 2	3615	a5cee71	rKDEVELOPe802ca5882a40cf916aecb50762e121d71189e87	Apr 29 2016, 5:09 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
e802ca5882a4	4fe06ebb3f6f	a5cee71e3133	Hannah von Reth	Only check --shared-mode if llvm is 3.8.0 or newer	Apr 29 2016, 5:09 PM