Fix localization of QML code
ClosedPublic
Actions

Authored by yurchor on Aug 26 2018, 7:15 AM.

Details

Reviewers

Aiix
lueck

Group Reviewers

Localization

Commits

R846:164602da8171: Fix localization of QML code

Summary

The current code contains untranslatable messages and word puzzles [1]. This patch tries to resolve them.

Test Plan

Extraction works fine, but compilability and applicability to the real world plasmoid have not been tested yet.

Repository

R846 Mycroft Plasma integration

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

yurchor requested review of this revision.Aug 26 2018, 7:15 AM

You could take the opportunity to change the ‘French’ punctuation in the three "%1 : %2" strings to proper English punctuation, i.e. "%1: %2".

Getting rid of French punctuation

probably the strings with "%1 : %2" need context for propr tarnslation

plasmoid/contents/ui/CurrentWeatherType.qml
191	missing Unit?
219	missing Unit?
247	missing Unit?
plasmoid/contents/ui/DashWeatherDelegate.qml
189	missing Unit and context for %1, %2?
239	missing Unit and context for %1, %2?
453	missing context for D + T
579	missing context for D + T
plasmoid/contents/ui/PlacesDelegate.qml
106	missing context for mtrs

Adding more context to the messages

This revision is now accepted and ready to land.Aug 28 2018, 5:24 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			plasmoid/contents/ui/AskMessageTypeMenu.qml (4 lines)
M			plasmoid/contents/ui/AudioFileDelegate.qml (4 lines)
M			plasmoid/contents/ui/BookDelegate.qml (12 lines)
M			plasmoid/contents/ui/CurrentWeatherType.qml (10 lines)
M			plasmoid/contents/ui/DashCryptoDelegate.qml (12 lines)
M			plasmoid/contents/ui/DashNewsDelegate.qml (8 lines)
M			plasmoid/contents/ui/DashWeatherDelegate.qml (36 lines)
M			plasmoid/contents/ui/DashboardDelegate.qml (2 lines)
M			plasmoid/contents/ui/Disclaimer.qml (2 lines)
M			plasmoid/contents/ui/DisclaimerCardDelegate.qml (6 lines)
M			plasmoid/contents/ui/DocumentFileDelegate.qml (2 lines)
M			plasmoid/contents/ui/ImgRecogType.qml (4 lines)
M			plasmoid/contents/ui/MsmView.qml (15 lines)
M			plasmoid/contents/ui/PlacesDelegate.qml (6 lines)
M			plasmoid/contents/ui/RecipeDelegate.qml (12 lines)
M			plasmoid/contents/ui/SimpleMessageTypeMenu.qml (4 lines)
M			plasmoid/contents/ui/StackObjDelegate.qml (8 lines)
M			plasmoid/contents/ui/StackObjType.qml (2 lines)
M			plasmoid/contents/ui/StockPriceWidget.qml (8 lines)
M			plasmoid/contents/ui/TomorrowWeatherType.qml (14 lines)
M			plasmoid/contents/ui/VideoFileDelegate.qml (4 lines)
M			plasmoid/contents/ui/YelpDelegate.qml (12 lines)
M			plasmoid/contents/ui/main.qml (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	40450			Aug 26 2018, 7:09 AM	★	★
Diff 2	40458			Aug 26 2018, 9:34 AM	★	★
Diff 3	40460			Aug 26 2018, 10:26 AM	★	★
Diff 4	40531	af778b0	R846:164602da8171536b04db32da16e2152910f616ea	Aug 28 2018, 5:35 AM	★	★