Differential D15077

Remove KIcon from plugins
ClosedPublic
Actions

Authored by stefanocrocco on Aug 25 2018, 11:45 AM.

Details

Reviewers
dfaure
Commits
R226:081e99282e93: Remove KIcon from plugins
Summary

Remove KIcon from plugins (it wasn't used in Konqueror itself). This is another step towards removing use of KDELibs4Support

Plugins which currently aren't build haven't been changed

Diff Detail

Repository
R226 Konqueror
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
stefanocrocco requested review of this revision.Aug 25 2018, 11:45 AM
stefanocrocco created this revision.
stefanocrocco updated this revision to Diff 40415.Aug 25 2018, 11:46 AM

Update for latest master

stefanocrocco edited the summary of this revision. (Show Details)Aug 25 2018, 11:48 AM
stefanocrocco added a reviewer: dfaure.
dfaure requested changes to this revision.Aug 25 2018, 12:02 PM
dfaure added inline comments.
plugins/kimgalleryplugin/imgallerydialog.cpp
96

That's quite indirect (pixmap->icon->pixmap), with risk of unwanted scaling.

I'd do QIcon::fromTheme("fill-color").
The widget will take care of requesting the size it wants.

Same for the next two.

This revision now requires changes to proceed.Aug 25 2018, 12:02 PM
stefanocrocco updated this revision to Diff 40417.Aug 25 2018, 12:34 PM

Use QIcon::fromTheme instead of QIcon()

dfaure accepted this revision.Aug 27 2018, 10:42 AM
This revision is now accepted and ready to land.Aug 27 2018, 10:42 AM
Closed by commit R226:081e99282e93: Remove KIcon from plugins (authored by stefanocrocco). · Explain WhyAug 27 2018, 12:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40506

View Options

plugins/kimgalleryplugin/imgallerydialog.cpp

Loading...
View Options

plugins/validators/reportdialog.cpp

Loading...