Change the evaluate worksheet icon at worksheet entry from view-refresh to system-run
ClosedPublic

Authored by filipesaraiva on Aug 23 2018, 12:18 AM.

Details

Summary

Currently the icon in worksheet entry is an icon for "refresh/update" something. The use of "run" icon is consistent with the action in Cantor window and it improves a bit the usability for run worksheet entries.

Diff Detail

Repository
R55 Cantor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipesaraiva created this revision.Aug 23 2018, 12:18 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptAug 23 2018, 12:18 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
filipesaraiva requested review of this revision.Aug 23 2018, 12:18 AM
filipesaraiva edited the summary of this revision. (Show Details)Aug 23 2018, 12:22 AM
filipesaraiva added reviewers: asemke, sirgienko.
filipesaraiva added a project: Cantor.

@filipesaraiva in 6b722430ec6120acef7b99c54a0ed5c607c56bae I set the icon for the "Insert Command Entry" item in the context menu to "run-build". Should we use the same icon, either system-run or run-build, in the context menu to insert an entry and in the action bar to execute it?

sirgienko resigned from this revision.Aug 25 2018, 11:01 AM

I haven't KDE themes, so questions about icons belongs @asemke .

@filipesaraiva in 6b722430ec6120acef7b99c54a0ed5c607c56bae I set the icon for the "Insert Command Entry" item in the context menu to "run-build". Should we use the same icon, either system-run or run-build, in the context menu to insert an entry and in the action bar to execute it?

I think for this case we need use two different icons because there are two different actions: one action is add a command entry, the other action is run the command entry.

Maybe could we use the "system-run" to add command entries? I like that square around the play symbol, it looks like a command entry itself. For run commands, I was thinking if the "media-playback-start" is enough for us because it is just the play symbol, like a run application in some IDEs.

See the figures below presenting "media-playback-start" in command worksheet and in Cantor window, respectively.

@filipesaraiva in 6b722430ec6120acef7b99c54a0ed5c607c56bae I set the icon for the "Insert Command Entry" item in the context menu to "run-build". Should we use the same icon, either system-run or run-build, in the context menu to insert an entry and in the action bar to execute it?

I think for this case we need use two different icons because there are two different actions: one action is add a command entry, the other action is run the command entry.

Makes sense.

Maybe could we use the "system-run" to add command entries? I like that square around the play symbol, it looks like a command entry itself.

We use already system-run for the action in the toolbar and in the main menu to evaluate the whole worksheet. That square around the play symbols also resembles our worksheet...

For run commands, I was thinking if the "media-playback-start" is enough for us because it is just the play symbol, like a run application in some IDEs.

See the figures below presenting "media-playback-start" in command worksheet and in Cantor window, respectively.

media-playback-start looks nice.

Should we use system-run for "evaluate worksheet", build-run for "insert command entry" and media-playback-start for "evaluate entry"?

Change the "view-refresh" icon in command entry to "media-playback-start"

Should we use system-run for "evaluate worksheet", build-run for "insert command entry" and media-playback-start for "evaluate entry"?

I agree. Done in last update.

asemke accepted this revision.Aug 26 2018, 9:21 PM
This revision is now accepted and ready to land.Aug 26 2018, 9:21 PM
This revision was automatically updated to reflect the committed changes.