Differential D15009

Add kdev-clang-tidy to appimage build
ClosedPublic
Actions

Authored by kossebau on Aug 22 2018, 10:52 PM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R32:594a1edb20cd: Add kdev-clang-tidy to appimage build

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Aug 22 2018, 10:52 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptAug 22 2018, 10:52 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
kossebau requested review of this revision.Aug 22 2018, 10:52 PM
kossebau added a comment.Aug 22 2018, 10:54 PM

Untested proposal to add kdev-clang-tidy to appimages builds for master at least for now.
Should allow more people to test the plugin while it is enhanced.

kossebau added inline comments.Aug 22 2018, 10:56 PM
appimage/kdevelop-recipe-centos6.sh
454 ↗(On Diff #40262)

Hups, these changes sneaked in from my stash. Though might be something to consider as well, now that it is up :)
Aligns the desktop file content more with what the normal desktop file has.

Actually I wonder if this file could not be generated from the real one, thus also have all the translations?

kfunk accepted this revision.Aug 23 2018, 6:55 AM
This revision is now accepted and ready to land.Aug 23 2018, 6:55 AM
kfunk added a comment.Aug 23 2018, 6:55 AM

That's for 5.3 branch, correct?

kossebau added a comment.Aug 23 2018, 9:07 AM
In D15009#313846, @kfunk wrote:

That's for 5.3 branch, correct?

Patch draft here is against master, as I have no experience with doing appimages, just made a theoretic change :)

Would be fine for 5.3 as well, yes. The more potential users, the better.

Have to leave the real patch and testing it to you, please take the idea and run with it.

One thing to be aware of: kdev-clang-tidy only has a single branch currently, master, any releases are for now only addressable by the tags (thus the v in "v0.2.0").

kfunk added a comment.Aug 23 2018, 9:47 AM

Understood. Go ahead and push to 5.3 please (b/c that's the branch we currently build AppImages for)

Closed by commit R32:594a1edb20cd: Add kdev-clang-tidy to appimage build (authored by kossebau). · Explain WhyAug 23 2018, 10:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40286

View Options

appimage/kdevelop-recipe-centos6.sh

Loading...