[PanelShadows] Use 0 offset for disabled borders on Wayland
ClosedPublic

Authored by zzag on Aug 22 2018, 11:58 AM.

Details

Summary

On Wayland, if some border is disabled, we don't attach corresponding
empty tile. Yet, we set offset of 1 for that border.

KWin relies on offset values to calculate bounding box for shadows.

For example, if a panel has only top border enabled, then the bounding
box will be 2 pixel wider(and 1px taller) than it should be. This can
result in having 1px thin artefacts on neighboring screens.

In general, we don't have to attach empty tiles for disabled borders.
Thus, we can set corresponding offsets to 0.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Aug 22 2018, 11:58 AM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 22 2018, 11:58 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
zzag requested review of this revision.Aug 22 2018, 11:58 AM
davidedmundson accepted this revision.Aug 22 2018, 12:06 PM
This revision is now accepted and ready to land.Aug 22 2018, 12:06 PM
zzag edited the summary of this revision. (Show Details)Aug 22 2018, 4:36 PM
This revision was automatically updated to reflect the committed changes.