Differential D14976

Less aggessive monochroming of icons
ClosedPublic
Actions

Authored by mart on Aug 21 2018, 3:53 PM.

Details

Reviewers
vkrause
Group Reviewers
Kirigami
Commits
R169:e8a611b3eaf5: Less aggessive monochroming of icons
Summary

Get rid of the heuristic about coloring icons less than 48 in desktopicon.cpp,
now all direct usage of Kirigami.Icon will need to have isMask:true for the coloring to happen
BasicListItem will now always try to color (ie needing on android to have all icons in basicListItems
included globaldrawer and contextdrawer to be monochrome)
this should not break too much existing apps but

Test Plan

tried in the gallery with both desktop and material styles, the behavior is as expected in both cases

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Aug 21 2018, 3:53 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptAug 21 2018, 3:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Aug 21 2018, 3:53 PM
mart changed the visibility from "Public (No Login Required)" to "No One".Aug 21 2018, 3:53 PM
mart retitled this revision from customIconColoring Theme api to Less aggessive monochroming of icons.
mart edited the summary of this revision. (Show Details)
mart planned changes to this revision.Aug 21 2018, 3:57 PM
mart requested review of this revision.Aug 22 2018, 9:09 AM
mart edited the test plan for this revision. (Show Details)
mart added reviewers: Kirigami, vkrause.
mart changed the visibility from "No One" to "All Users".
mart changed the visibility from "All Users" to "Public (No Login Required)".
vkrause added a comment.Aug 22 2018, 9:19 AM

Thanks! This looks like it should fix my problem with the breeze weather icons on Android :)

This revision was not accepted when it landed; it landed in state Needs Review.Aug 22 2018, 11:02 AM
Closed by commit R169:e8a611b3eaf5: Less aggessive monochroming of icons (authored by mart). · Explain Why
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 3 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 40209