Differential D14951

Fix the workaround for cookie expiration date in WebEnginePart
ClosedPublic
Actions

Authored by stefanocrocco on Aug 20 2018, 2:27 PM.

Details

Reviewers
dfaure
Commits
R226:d784b8bb01dd: Fix the workaround for cookie expiration date in WebEnginePart
Summary

The workaround for the bug with cookie expiration date in KCookieJar
assumes that QNetworkCookie::expirationDate is in local time. However, it
seems this isn't always the case. To solve this problem, rather than set the
timezone to GMT, manually add the offset between UTC and system time zone to the
date.

Diff Detail

Repository
R226 Konqueror
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
stefanocrocco requested review of this revision.Aug 20 2018, 2:27 PM
stefanocrocco created this revision.
dfaure accepted this revision.Aug 20 2018, 2:40 PM

Bleh, just use KIO 5.50 :-)

This revision is now accepted and ready to land.Aug 20 2018, 2:40 PM
Closed by commit R226:d784b8bb01dd: Fix the workaround for cookie expiration date in WebEnginePart (authored by stefanocrocco). · Explain WhyAug 20 2018, 3:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40059

View Options

webenginepart/src/webenginepartcookiejar.cpp

Loading...