Create new bookmark items near the current one (over it)
ClosedPublic

Authored by giacomob on Aug 19 2018, 3:18 PM.

Details

Summary

Currently in the bookmarks manager the user can create new items via the contextual menu, so a position is implicitly chosen, but the new items are always inserted at the first position in the list.

This change aims to add new items just before the current (selected) one. If the selected item is a folder the behavior is unchanged (the new item will be inserted at the first position in that folder).

Test Plan
  • Select a separator/url item
  • Add a new item (separator/url/folder)
  • The new item is inserted just before the previously selected one

Diff Detail

Repository
R875 Falkon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
giacomob created this revision.Aug 19 2018, 3:18 PM
Restricted Application added a project: Falkon. · View Herald TranscriptAug 19 2018, 3:18 PM
Restricted Application added a subscriber: falkon. · View Herald Transcript
giacomob requested review of this revision.Aug 19 2018, 3:18 PM
cullmann added a subscriber: cullmann.

Hi, any input on this?

drosca accepted this revision.Dec 12 2018, 7:34 PM
This revision is now accepted and ready to land.Dec 12 2018, 7:34 PM

Could you tell me the real-name + email for the commit? I can push it for you, if you have no account.

Thanks,
giacomosrv@gmail.com
Giacomo Barazzetti

This revision was automatically updated to reflect the committed changes.