Don't try to read X11 properties on ShellClient
AbandonedPublic
Actions

Authored by graesslin on Apr 25 2016, 3:28 PM.

Details

Reviewers

None

Group Reviewers

Summary

Effects and Shadow tried to read X11 properties unconditionally on
the window id. If the window id is not an X11 id this is going to fail.

This change introduced a check on whether the Toplevel is a ShellClient
and in that case the property is not read.

Repository

R108 KWin

Branch

guard-reading-x11-properties

Lint

No Linters Available

Unit

No Unit Test Coverage

graesslin retitled this revision from to Don't try to read X11 properties on ShellClient.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added a reviewer: Plasma.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart added inline comments.

effects.cpp
1672	couldn't this become a virtual instead?

effects.cpp
1672	I don't really see a good way to expose this through a virtual and well the virtual check would do pretty much the same ;-) I'll think about it.

			Path	Packages
M			effects.cpp (4 lines)
M			shadow.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3516	537cc14		Apr 25 2016, 3:28 PM	★	★