Differential D14790

use QProcess instead of KProcess
ClosedPublic
Actions

Authored by vanini on Aug 13 2018, 12:14 PM.

Details

Reviewers
sitter
Commits
R550:8453986756bf: use QProcess instead of KProcess
Summary
  • Replace KProcess with QProcess, since we are not using any of its additional features.
  • Use xi18n for text containing KUIT tags.
  • Delete QProcess object for sources editor when it finished.
  • Use new connect syntax.

Diff Detail

Repository
R550 Muon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vanini requested review of this revision.Aug 13 2018, 12:14 PM
vanini created this revision.
vanini added a comment.Aug 13 2018, 12:17 PM

I added a paragraph in the message box because, apparently, KMessageBox only wraps rich text when it it wider than 50% of the screen, which looks terrible on a wide screen.

sitter requested changes to this revision.Aug 13 2018, 1:52 PM

I think you need to set ForwardedChannels on the qprocess for this to not behave differently than the kprocess code.

src/muonapt/QAptActions.cpp
417–420

in cmake we still to require >=5.2. using qoverload would definitely need that bumped to >=5.7

541–548
  • on the wrong side of the space
This revision now requires changes to proceed.Aug 13 2018, 1:52 PM
vanini updated this revision to Diff 39611.Aug 13 2018, 3:38 PM
  • pointer syntax
  • Require Qt 5.7
  • set forwarded channels on the processes
vanini marked 2 inline comments as done.Aug 13 2018, 3:39 PM
sitter accepted this revision.Sep 13 2018, 12:41 PM
This revision is now accepted and ready to land.Sep 13 2018, 12:41 PM
Closed by commit R550:8453986756bf: use QProcess instead of KProcess (authored by vanini). · Explain WhySep 24 2018, 5:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
Msrc/muonapt/QAptActions.cpp (40 lines)

Diff 42263

View Options

CMakeLists.txt

Loading...
View Options

src/muonapt/QAptActions.cpp

Loading...