| drosca |
| Falkon |
Falkon has a feature to automatically close the tab that was specifically
opened for the file to download, because this kind of tab has no useful
purpose to the user.
In the case where the main window would have been closed, Falkon
would crash de-referencing the now NULL pointer to the main window.
This patch adds a simple check to do nothing in this case, as there is no
tab to close anyway.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Why not just
if (mApp->getWindow() && testWebView(mApp->getWindow()->weView(), url)) {
...
}Hello David,
I initially checked for mApp->getWindow() separately because when it is null there is no need to go any further, so it seemed simpler to me to directly stop instead of continuing (and couting on people looking at the code guessing that the rest of the code would do nothing in this case);
Furthermore I introduced the variable to query getWindow only once by habit because I prefer to explicit optimisations instead of counting on the compiler (and in this case the optimisation does not happen).
But as you are the project leader (and I thank you for the project), if you want the patch the way you proposed, just confirm me and you'll have it as fast as possible (no need to let that bug lie around).
Hello David,
I propose using Christophe CURIS <christophe.curis@free.fr>
Regards,
Christophe