Rewrite Python2 to dbus server
ClosedPublic

Authored by sirgienko on Aug 7 2018, 8:58 PM.

Diff Detail

Repository
R55 Cantor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sirgienko created this revision.Aug 7 2018, 8:58 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptAug 7 2018, 8:58 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
sirgienko requested review of this revision.Aug 7 2018, 8:58 PM
sirgienko updated this revision to Diff 39421.Aug 10 2018, 5:30 PM

Merge PythonDbusSession to PythonSession

Hi @sirgienko, what about the support for this backend in other OS? In past we throught about drop dbus because it is unfortunately not supported in Windows and OS X.

Hi @sirgienko, what about the support for this backend in other OS? In past we throught about drop dbus because it is unfortunately not supported in Windows and OS X.

Hi @filipesaraiva, in this moment Python 3 use dbus for communication with server. And Python 2 don't use server, so we have bug 363606. In this commit I apply python server code from Python 3 also for Python 2. In future we plan remove dbus code and use QProcess (or KProcess) for this.

Hi @filipesaraiva, in this moment Python 3 use dbus for communication with server. And Python 2 don't use server, so we have bug 363606. In this commit I apply python server code from Python 3 also for Python 2. In future we plan remove dbus code and use QProcess (or KProcess) for this.

Ok, thank you for all your work to Cantor.

@sirgienko can we completely get rid of Python3Session and Python2Session and use one single class PythonSession only? We can have PythonSession with an additional parameter for python version and depending on this parameter we'll start the proper python_server.

sirgienko updated this revision to Diff 39443.Aug 11 2018, 10:35 AM

Add forgotten changes and fix build error

asemke accepted this revision.Aug 11 2018, 12:23 PM
This revision is now accepted and ready to land.Aug 11 2018, 12:23 PM
This revision was automatically updated to reflect the committed changes.