Differential D1466

Properly kill libarchive jobs
ClosedPublic
Actions

Authored by elvisangelaccio on Apr 23 2016, 12:10 PM.

Details

Reviewers
rthomsen
Commits
R36:8c21ca3ae932: libarchive: properly stop all jobs
Summary

We just need use the m_abortOperation flag, like we already do for ListJobs.

However killing an AddToArchive jobs still would crash Ark. Dropping the
disconnect() in the Job dtor seems to fix this.

Test Plan

libarchive AddJobs are now properly killed (both using the systray button or
closing the Ark window).

cliinterface is still broken for now.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 3472.Apr 23 2016, 12:10 PM
elvisangelaccio retitled this revision from to Properly kill libarchive AddJobs.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptApr 23 2016, 12:10 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
elvisangelaccio updated this revision to Diff 3473.Apr 23 2016, 12:51 PM
  • Try also to fix libarchive ExtractJobsx
elvisangelaccio updated this revision to Diff 3474.Apr 23 2016, 1:07 PM
  • Fix also DeleteJobs
rthomsen accepted this revision.Apr 23 2016, 1:11 PM
rthomsen edited edge metadata.

Ship it!!! :)

This revision is now accepted and ready to land.Apr 23 2016, 1:11 PM
elvisangelaccio retitled this revision from Properly kill libarchive AddJobs to Properly kill libarchive jobs.Apr 23 2016, 1:11 PM
elvisangelaccio edited edge metadata.
Closed by commit R36:8c21ca3ae932: libarchive: properly stop all jobs (authored by elvisangelaccio). · Explain WhyApr 23 2016, 1:24 PM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio mentioned this in R36:8c21ca3ae932: libarchive: properly stop all jobs.

Revision Contents
Changeset List

Diff 3475

View Options

kerfuffle/jobs.cpp

Loading...
View Options

plugins/libarchive/libarchiveplugin.h

Loading...
View Options

plugins/libarchive/libarchiveplugin.cpp

Loading...
View Options

plugins/libarchive/readwritelibarchiveplugin.cpp

Loading...