Differential D14658

SymbolView: Avoid unneeded ask for document type
AbandonedPublic
Actions

Authored by loh.tar on Aug 6 2018, 6:04 PM.

Details

Reviewers
sars
Group Reviewers
Kate
Summary
This may for its own not a big improvement but reduced the code slightly
and will save even more lines with the upcoming patch to save the view
settings individual for each parser
Test Plan

Reply the comments in the diff

Diff Detail

Repository
R40 Kate
Lint
Lint Skipped
Unit
Unit Tests Skipped
loh.tar created this revision.Aug 6 2018, 6:04 PM
Restricted Application added a project: Kate. · View Herald TranscriptAug 6 2018, 6:04 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.Aug 6 2018, 6:04 PM
sars added a comment.Aug 7 2018, 7:01 AM

Adding a member-variable to avoid one getter cal is just adding complexity and saves you almost nothing.

loh.tar abandoned this revision.Aug 10 2018, 6:54 PM

unwelcome

Revision Contents
Changeset List

Diff 39215

View Options

addons/symbolviewer/plugin_katesymbolviewer.h

Loading...
View Options

addons/symbolviewer/plugin_katesymbolviewer.cpp

Loading...