Differential D14638

Show new messages on the bottom
ClosedPublic
Actions

Authored by nicolasfella on Aug 5 2018, 8:50 PM.

Details

Reviewers
sredman
Group Reviewers
KDE Connect
Commits
R224:5f63f78f77c2: Show new messages on the bottom
Summary

Like every messaging app I know does

Test Plan

Compare message order with phone

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Aug 5 2018, 8:50 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptAug 5 2018, 8:50 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Aug 5 2018, 8:50 PM
sredman requested changes to this revision.Aug 5 2018, 10:15 PM
sredman added a subscriber: sredman.

Thank goodness for this. I was trying to figure this out on my own but I couldn't quite get it working (even to the point of sorting)

I am not able to send SMS with this patch. If you change line 67 of smsapp/qml/ConversationDisplay.qml from model.sendReplyToConversation(message.text) to model.sourceModel.sendReplyToConversation(message.text) it works again. I can't figure out how to use arc to push that tiny change, though!

This revision now requires changes to proceed.Aug 5 2018, 10:15 PM
nicolasfella updated this revision to Diff 39155.Aug 5 2018, 10:19 PM
  • Fix send

It took me a while to figure it out, too

sredman accepted this revision.Aug 5 2018, 10:20 PM
This revision is now accepted and ready to land.Aug 5 2018, 10:20 PM
Closed by commit R224:5f63f78f77c2: Show new messages on the bottom (authored by nicolasfella). · Explain WhyAug 5 2018, 10:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 39157

View Options

smsapp/conversationmodel.h

Loading...
View Options

smsapp/qml/ConversationDisplay.qml

Loading...