Differential D14635

Refine SMS conversation view
ClosedPublic
Actions

Authored by nicolasfella on Aug 5 2018, 7:50 PM.

Tags

Subscribers

sredman, kdeconnect

Details

Reviewers

Group Reviewers

Commits

R224:21b52d7dcfbb: Refine SMS conversation view

Summary

Use components from Kaidan messenger

Diff Detail

Repository

R224 KDE Connect

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nicolasfella created this revision.Aug 5 2018, 7:50 PM

Restricted Application added a project: KDE Connect. · View Herald TranscriptAug 5 2018, 7:50 PM

Restricted Application added a subscriber: kdeconnect. · View Herald Transcript

nicolasfella requested review of this revision.Aug 5 2018, 7:50 PM

Harbormaster completed remote builds in B1542: Diff 39146.Aug 5 2018, 7:50 PM

fix diff

Harbormaster completed remote builds in B1543: Diff 39147.Aug 5 2018, 7:51 PM

Looks way better than before! I was getting a crash when scrolling up and down on the smslayout branch but that seems to be cleared away here

smsapp/qml/RoundImage.qml
3	I don't know the rules/best practices on these things: Should the copyright header be changed to say KDE Connect?

This revision is now accepted and ready to land.Aug 5 2018, 9:55 PM

Closed by commit R224:21b52d7dcfbb: Refine SMS conversation view (authored by nicolasfella). · Explain WhyAug 5 2018, 10:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
A	M		smsapp/qml/ChatMessage.qml (111 lines)
M			smsapp/qml/ConversationDisplay.qml (14 lines)
A	M		smsapp/qml/RoundImage.qml (52 lines)
M			smsapp/resources.qrc (2 lines)

Diff 39153

smsapp/qml/ChatMessage.qml

Loading...

smsapp/qml/ConversationDisplay.qml

Loading...

smsapp/qml/RoundImage.qml

Loading...

smsapp/resources.qrc

Loading...