SymbolView: Reduce headache risk for the coder
AbandonedPublic

Authored by loh.tar on Aug 4 2018, 7:12 PM.

Details

Reviewers
sars
Group Reviewers
Kate
Summary

...by renaming KatePluginSymbolViewerView -> SymbolView

Diff Detail

Repository
R40 Kate
Lint
Lint Skipped
Unit
Unit Tests Skipped
loh.tar created this revision.Aug 4 2018, 7:12 PM
Restricted Application added a project: Kate. · View Herald TranscriptAug 4 2018, 7:12 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.Aug 4 2018, 7:12 PM
sars added a comment.Aug 5 2018, 8:08 AM

Of this one I'm not convinced ;)

What do we gain by changing the name? It is a bit long, but I don't see it as hurting readability that much... The current name is also more along the line of most other plugins.

Of this one I'm not convinced ;)

too bad :-(

What do we gain by changing the name? It is a bit long, but I don't see it as hurting readability that much...

I did not choose the commit message without reason, it hurts me every time I have to think about it. The lengh is not nice but not the real problem, the name is just pointless.

The current name is also more along the line of most other plugins.

I see, but then should they fixed too ;-)

btw, D14515 is visible to you?

loh.tar abandoned this revision.Aug 10 2018, 6:53 PM

unwelcome