Differential D14588

Deduplicate default filename template code
ClosedPublic
Actions

Authored by rkflx on Aug 3 2018, 9:58 PM.

Details

Reviewers
ngraham
Group Reviewers
Spectacle
Maniphest Tasks
T9252: Improve default filename when saving
Commits
R166:982555d911eb: Deduplicate default filename template code
Summary

In preparation for user-visible improvements to the default filenames,
let's move the corresponding code around so that it only has to be
touched in a single place, preventing strings getting out of sync with
time.

Ref T9252

Test Plan

Configure → Save dialog page should look like before, and
Save with a fresh config should populate the filename as usual.

Diff Detail

Repository
R166 Spectacle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rkflx requested review of this revision.Aug 3 2018, 9:58 PM
rkflx created this revision.
rkflx updated this revision to Diff 39214.EditedAug 6 2018, 5:54 PM
  • Use function instead of static const
In http://phabricator.kde.org/D14631, dfaure wrote:

Make all these functions rather than variables. It will speed up starting time (right now all those QStrings have to be created upfront).

Let's follow this advice for Spectacle too.

rkflx added a subscriber: ngraham.Aug 9 2018, 1:13 PM

Anybody else from Spectacle wanna review this, since @ngraham is busy? (When I asked in the task whether to commit directly, the answer was a bit ambiguous…).

ngraham accepted this revision.Aug 10 2018, 4:44 PM

+1, nice refactoring. I approve of the code changes, and the user-facing behavior isn't impacted.

This revision is now accepted and ready to land.Aug 10 2018, 4:44 PM
Closed by commit R166:982555d911eb: Deduplicate default filename template code (authored by rkflx). · Explain WhyAug 10 2018, 7:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 39427

View Options

src/ExportManager.cpp

Loading...
View Options

src/Gui/SettingsDialog/SaveOptionsPage.cpp

Loading...
View Options

src/SpectacleConfig.h

Loading...
View Options

src/SpectacleConfig.cpp

Loading...