Differential D14553

[effects/minimizeanimation] Use interpolate helper
ClosedPublic
Actions

Authored by zzag on Aug 2 2018, 12:29 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:950bf94f30a6: [effects/minimizeanimation] Use interpolate helper
Summary

That's not really "clear" what's going on with opacity values. Use
interpolate helper to improve a little bit readability.

Test Plan

Minimized/uniminized System Settings, still works as expected.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Aug 2 2018, 12:29 PM
Restricted Application added a project: KWin. · View Herald TranscriptAug 2 2018, 12:29 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Aug 2 2018, 12:29 PM
zzag added a comment.Aug 2 2018, 12:29 PM

"clear" because one have to think for a little bit what's going on, but I think with interpolate code is a little bit more readable.

davidedmundson accepted this revision.Aug 2 2018, 12:30 PM
This revision is now accepted and ready to land.Aug 2 2018, 12:30 PM
Closed by commit R108:950bf94f30a6: [effects/minimizeanimation] Use interpolate helper (authored by zzag). · Explain WhyAug 2 2018, 12:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38948

View Options

effects/minimizeanimation/minimizeanimation.cpp

Loading...