Implement volume overdrive
ClosedPublic

Authored by drosca on Apr 20 2016, 12:44 PM.

Details

Summary

It is now possible to set volume up to 150% from KCM.

BUG: 351438

Test Plan

For applet there will be config option to set maximum volume (100% - 150%), in next review.

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca retitled this revision from to Implement volume overdrive.Apr 20 2016, 12:44 PM
drosca updated this object.
drosca edited the test plan for this revision. (Show Details)
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptApr 20 2016, 12:44 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

I know Pavucontrol does the same, but I think this makes it too easy to go into overdrive.
There is a reason why "100%" is not the actual maximum volume you can get out of a device.
I don't want us to be liable for either burst speakers or burst eardrums...

Is there any way we can change the look of the part of the slider that is above 100%, like make it red or something? Or any way we can indicate "Hey, do this only if you know what you're doing!"

drosca updated this revision to Diff 3438.Apr 20 2016, 8:51 PM

Fix showing volume % in applet

There is a reason why "100%" is not the actual maximum volume you can get out of a device.
I don't want us to be liable for either burst speakers or burst eardrums...

Well, for most devices even 100% is too much so I wouldn't really see this as a problem.

Is there any way we can change the look of the part of the slider that is above 100%, like make it red or something? Or any way we can indicate "Hey, do this only if you know what you're doing!"

I'm afraid there is not much to do about slider customization (unless it is replaced by custom slider which then won't use widget style).

This revision was automatically updated to reflect the committed changes.