Differential D14519

Added HelloQml Extension
ClosedPublic
Actions

Authored by anmolgautam on Jul 31 2018, 5:07 PM.

Details

Reviewers
drosca
Commits
R875:0abde8b755b0: Added HelloQml Extension

Diff Detail

Repository
R875 Falkon
Lint
Lint Skipped
Unit
Unit Tests Skipped
anmolgautam created this revision.Jul 31 2018, 5:07 PM
Restricted Application added a project: Falkon. · View Herald TranscriptJul 31 2018, 5:07 PM
Restricted Application added a subscriber: falkon. · View Herald Transcript
anmolgautam requested review of this revision.Jul 31 2018, 5:07 PM
drosca requested changes to this revision.Aug 2 2018, 4:36 PM

It's missing Messages.sh script for extracting translatable strings (it also seems it doesn't use translations at all).

It is also very basic, it should use more functionality. What would be great is an example extension <-> webpage bridge = extension scheme + registering extra objects.

src/scripts/CMakeLists.txt
15

Should also exclude Messages.sh

This revision now requires changes to proceed.Aug 2 2018, 4:36 PM
anmolgautam updated this revision to Diff 39403.Aug 10 2018, 11:17 AM
  • modified HelloQml Extension
  • added messages.sh in cmake & extension page for helloqml
anmolgautam marked an inline comment as done.Aug 10 2018, 11:17 AM
drosca requested changes to this revision.Aug 10 2018, 4:02 PM
drosca added inline comments.
src/scripts/helloqml/Messages.sh
12

This also needs *.js

src/scripts/helloqml/helloqml.qml
20

I would like to see webpage JavaScript <-> QML extension bridge. So that means calling QML functions (or accessing properties, etc) from JavaScript on webpage.

This revision now requires changes to proceed.Aug 10 2018, 4:02 PM
anmolgautam updated this revision to Diff 39995.Aug 19 2018, 11:40 AM
  • improved plugin
anmolgautam updated this revision to Diff 39996.Aug 19 2018, 11:44 AM
  • added *.js to messages.sh
anmolgautam marked 2 inline comments as done.Aug 19 2018, 11:45 AM
drosca accepted this revision.Sep 2 2018, 8:33 PM
This revision is now accepted and ready to land.Sep 2 2018, 8:33 PM
anmolgautam updated this revision to Diff 42680.Oct 1 2018, 4:59 PM

This revision was accepted before the qml api revision and thus was using QtQuick.Window. But now since the apis are using QQuickWidget instead of QQuickWindow, so its updated to use Rectangle instead of Window.

drosca accepted this revision.Oct 1 2018, 6:19 PM
drosca added inline comments.
src/lib/plugins/qml/api/sidebar/qmlsidebar.cpp
156

This should go in separate commit.

anmolgautam updated this revision to Diff 42684.Oct 1 2018, 6:42 PM
anmolgautam marked an inline comment as done.
Closed by commit R875:0abde8b755b0: Added HelloQml Extension (authored by anmolgautam). · Explain WhyOct 1 2018, 9:37 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 3 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 42680

View Options

src/lib/plugins/qml/api/sidebar/qmlsidebar.cpp

Loading...
View Options

src/scripts/CMakeLists.txt

Loading...
View Options

src/scripts/helloqml/Messages.sh

Loading...
View Options

src/scripts/helloqml/helloqml.qml

Loading...