Details
Details
- Reviewers
drosca - Commits
- R875:0abde8b755b0: Added HelloQml Extension
Diff Detail
Diff Detail
- Repository
- R875 Falkon
- Branch
- patch-helloqml-extension-only
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 1992 Build 2010: arc lint + arc unit
Comment Actions
It's missing Messages.sh script for extracting translatable strings (it also seems it doesn't use translations at all).
It is also very basic, it should use more functionality. What would be great is an example extension <-> webpage bridge = extension scheme + registering extra objects.
src/scripts/CMakeLists.txt | ||
---|---|---|
15 | Should also exclude Messages.sh |
Comment Actions
- modified HelloQml Extension
- added messages.sh in cmake & extension page for helloqml
Comment Actions
This revision was accepted before the qml api revision and thus was using QtQuick.Window. But now since the apis are using QQuickWidget instead of QQuickWindow, so its updated to use Rectangle instead of Window.
src/lib/plugins/qml/api/sidebar/qmlsidebar.cpp | ||
---|---|---|
156 ↗ | (On Diff #42680) | This should go in separate commit. |