SymbolView Fix: Find current item when symbol is in first line
ClosedPublic

Authored by loh.tar on Jul 30 2018, 12:44 PM.

Details

Summary
This happens really rare because mostly is some comment above some symbol,
like copyright notice or shebang, so this bug was noticed while coding
a new parser type, plaint-text-parser
Test Plan

Open some source file and delete all above some function, so they starts in line 1 -> The selection in the symbol view disapears
Click from somewhere below these first function back into the first, the item is not selected.

With this patch it is.

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
loh.tar created this revision.Jul 30 2018, 12:44 PM
Restricted Application added a project: Kate. · View Herald TranscriptJul 30 2018, 12:44 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.Jul 30 2018, 12:44 PM
sars accepted this revision.Jul 30 2018, 2:02 PM

How do you prepare your diffs?

When I use the web-page (most of the time) I usually feed it a file that I create with just "git diff > path/to/file.diff" This gives a file that has the whole path in git and some git history hashes. This in combination with setting the right repository adds context information in the phabricator web-interface.

This revision is now accepted and ready to land.Jul 30 2018, 2:02 PM
This revision was automatically updated to reflect the committed changes.

How do you prepare your diffs?

"git show <commit>|xclip" The web interface did not grumble, but did also not extract all already available information. No I idea why that isn't implemented.
So, you have trouble with my stuff? If so, I will remove the the commit message the next time.