Details
Details
- Reviewers
apol - Group Reviewers
KDevelop - Commits
- R32:cfdaa12723cb: Fix two tests in test_gdb.
Diff Detail
Diff Detail
- Repository
- R32 KDevelop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
RE line 960.
What does QCOMPARE(stackModel->rowCount(), 4); actually check? I added printing for stackModel and running test multiple times gives me different results:
QDEBUG : KDevMI::GDB::GdbTest::testStackSwitchThread() "#1 at main" QDEBUG : KDevMI::GDB::GdbTest::testStackSwitchThread() "#2 at base_block_alloc" QDEBUG : KDevMI::GDB::GdbTest::testStackSwitchThread() "#3 at check_and_init_mutex"
QDEBUG : KDevMI::GDB::GdbTest::testStackSwitchThread() "#1 at main" QDEBUG : KDevMI::GDB::GdbTest::testStackSwitchThread() "#2 at malloc_mutex_unlock" QDEBUG : KDevMI::GDB::GdbTest::testStackSwitchThread() "#3 at __pthread_mutex_trylock" QDEBUG : KDevMI::GDB::GdbTest::testStackSwitchThread() "#4 at thread_start"
QDEBUG : KDevMI::GDB::GdbTest::testStackSwitchThread() "#1 at main" QDEBUG : KDevMI::GDB::GdbTest::testStackSwitchThread() "#2 at arena_stats_init" QDEBUG : KDevMI::GDB::GdbTest::testStackSwitchThread() "#3 at malloc_mutex_trylock_final"
This looks pretty system-specific, so I decided to just check that we have more that 2 rows, because the test uses first and second row for checks.