Differential D14466

Refresh monitor after hiding or showing a track
ClosedPublic
Actions

Authored by juku on Jul 29 2018, 5:31 PM.

Details

Reviewers
mardelle
alcinos
Commits
R158:4fa39c87a5af: Fix refresh on hide track

Diff Detail

Repository
R158 Kdenlive
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
juku requested review of this revision.Jul 29 2018, 5:31 PM
juku created this revision.
mardelle added a comment.Jul 31 2018, 7:19 AM

Thanks for your patch. We could add an additional check, because a refresh is needed only if we perform the hide operation on a video track. Refresh is unnecessary for audio track muting. So I would recommend adding a check for TrackModel::isAudioTrack() to decide if a refresh is useful.

juku updated this revision to Diff 38869.EditedJul 31 2018, 6:34 PM

True, thanks for the hint. I updated the patch. Currently requestMonitorRefresh() is actually still called multiple times in a row while starting Kdenlive or opening a project. Maybe it would be better to call it from QML after onClicked action?

mardelle accepted this revision.Aug 3 2018, 2:11 PM

Fine, thanks!

This revision is now accepted and ready to land.Aug 3 2018, 2:11 PM
Closed by commit R158:4fa39c87a5af: Fix refresh on hide track (authored by juku, committed by mardelle). · Explain WhyAug 3 2018, 2:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 39015

View Options

src/timeline2/model/timelineitemmodel.cpp

Loading...