Applet: Move Application streams with drag and drop
ClosedPublic
Actions

Authored by drosca on Apr 18 2016, 4:45 PM.

Details

Reviewers

Group Reviewers

Plasma: Design
Plasma

Commits

Summary

It is now possible to move streams to different device
by dragging the stream's icon.

Repository

R115 Plasma Audio Volume Applet

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

drosca retitled this revision from to Applet: Move Application streams with drag and drop.

drosca updated this object.

drosca edited the test plan for this revision. (Show Details)

drosca added a reviewer: Plasma.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

All thumbs up from the usability side!

sebas requested changes to this revision.Apr 18 2016, 7:54 PM

sebas added a reviewer: sebas.

sebas added a subscriber: sebas.

sebas added inline comments.

applet/contents/ui/ListItemBase.qml
46	I'd turn this into more lines, using if's instead of the ternary, that would make it way easier to read.
54	Same here, make it more readable by spreading over multiple lines
applet/contents/ui/main.qml
86	accolade on the same line as the function definition
99	accolade on the same line as the function definition

This revision now requires changes to proceed.Apr 18 2016, 7:54 PM

Fix issues

Sorry it took so long. Looks seriously nice!

This revision is now accepted and ready to land.May 5 2016, 12:47 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			applet/contents/ui/ListItemBase.qml (47 lines)
M			applet/contents/ui/main.qml (42 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3403	ec9cd6d		Apr 18 2016, 4:45 PM	★	★
Diff 2	3435	ec9cd6d	Fix issues	Apr 20 2016, 1:20 PM	★	★
Diff 3	3663	569fa9a	rPLASMAPA94df728fb1aa31eb8711928d48bffffaf73a6b8e	Apr 27 2016, 10:37 AM	★	★