Differential D14423

Mingw compile fix
ClosedPublic
Actions

Authored by habacker on Jul 27 2018, 7:53 AM.

Details

Reviewers

mlaurent

Commits

R871:7251f8234730: Mingw compile fix

Summary

fix finding of bfd, intl, iberty and z library
fix drkonqi compile issue (missing functions setenv/unsetenv) by adding kdewin
fix include filename case issues on cross compiling
fix missing includes

BUG:396821
FIXED-IN:5.13.4

Test Plan

cross compiled on SUSE obs

Diff Detail

Repository

R871 DrKonqi

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

habacker created this revision.Jul 27 2018, 7:53 AM

Restricted Application added a project: Plasma. · View Herald TranscriptJul 27 2018, 7:53 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

habacker requested review of this revision.Jul 27 2018, 7:53 AM

Harbormaster completed remote builds in B1248: Diff 38563.Jul 27 2018, 7:53 AM

ping

Any chance to get a review ?

habacker edited reviewers, added: mlaurent; removed: jriddell.Aug 14 2018, 5:06 AM

For me it seems ok :)
I can't test it.

> +2 I trust you :)

This revision is now accepted and ready to land.Aug 17 2018, 11:25 AM

For the record: This patch is used to cross build drkonqi for windows at https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win32:KF547/mingw32-drkonqi5

Closed by commit R871:7251f8234730: Mingw compile fix (authored by habacker). · Explain WhyAug 17 2018, 11:48 AM

This revision was automatically updated to reflect the committed changes.

In D14423#310711, @mlaurent wrote:

I can't test it.

You can

On a linux system with installed osc, (see https://en.opensuse.org/openSUSE:OSC for more details) run

osc co home:rhabacker:branches:windows:mingw:win32:KF547/mingw32-drkonqi5
cd home:rhabacker:branches:windows:mingw:win32:KF547/mingw32-drkonqi5
osc build openSUSE_Leap_42.3

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (44 lines)
M			src/CMakeLists.txt (7 lines)
M			src/drkonqibackends.cpp (2 lines)
M			src/kdbgwin/CMakeLists.txt (7 lines)
M			src/kdbgwin/abstract_generator.h (2 lines)
M			src/kdbgwin/abstract_generator.cpp (4 lines)
M			src/kdbgwin/common.h (20 lines)
M			src/kdbgwin/main.cpp (4 lines)
M			src/kdbgwin/mingw_generator.cpp (2 lines)
M			src/kdbgwin/process.h (3 lines)