Differential D14422

Add edid converter
Needs ReviewPublic
Actions

Authored by gladhorn on Jul 27 2018, 7:46 AM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

Make it convenient to work with various EDID formats by dumping the
decoded EDID in bin/hex/base64.

Diff Detail

Repository
R110 KScreen Library
Branch
autotest
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1247
Build 1261: arc lint + arc unit
gladhorn created this revision.Jul 27 2018, 7:46 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 27 2018, 7:46 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gladhorn requested review of this revision.Jul 27 2018, 7:46 AM
zzag added a subscriber: zzag.Jul 27 2018, 8:18 AM
zzag added inline comments.
tests/edid_converter.cpp
27

Why do you need EdidHelper class? Would be better to have just functions.

98

It would be better to not use else if after return statement, IMHO.

Revision Contents
Changeset List

PathPackages
Mtests/CMakeLists.txt (3 lines)
AMtests/edid_converter.cpp (104 lines)
Mtests/testpnp.cpp (19 lines)
AMtests/utils.h (45 lines)

Diff 38562

View Options

tests/CMakeLists.txt

Loading...
View Options

tests/edid_converter.cpp

Loading...
View Options

tests/testpnp.cpp

Loading...
View Options

tests/utils.h

Loading...